hunterhacker/jdom — Issue #59: JDOMConstants should be final class not interface
Author: rolfl
Created: 2012-01-17 13:37:25+00:00
State: open

From Thomas

> One other thing I noticed is the practice of making JDOMConstants an
> interface. Usually interface means something like
>
> if (o instanceof (JDOMConstants)){
>	((JDOMConstance)o).doSomething();
> }
>
> It would be "better" code to make JDOMConstants a final class with
> private constructor and use "import static JDOMConstants.*" where you
> need it. That would not result in such statements: "Element _is a_
> JDOMConstants".