TheYeti/mcMMO — Issue #19: mcMMO mass checking skills every second whilst standing still.
Author: KeithWard
Created: 2012-01-14 18:49:07+00:00
State: open

mcMMO appears to be mass checking skills ability permissions even whilst standing still and holding nothing.

This appears to be from a timer which calls Skills.monitorSkills() every second, In my opinion if anything it should only need to check if i actually do anything as opposed to every second, however whether it can be refactored to do so i'm unsure, unfortunately i'm not familliar enough with the bukkit API at the moment to say either way (i'll see if i can scroll through the API later on tonight).

This is under PermissionsEX at least but as far as i'm aware it would extend to pretty much any Permissions system.

Example: (At this point I'm the only one on the server and I'm standing still holding no weapons) - the following is appearing in the debug log every second.

2012-01-14 18:26:48 [INFO] User CyberaX checked for "mcmmo.ability.herbalism", "*" found
2012-01-14 18:26:48 [INFO] User CyberaX checked for "mcmmo.ability.axes", "*" found
2012-01-14 18:26:48 [INFO] User CyberaX checked for "mcmmo.ability.woodcutting", "*" found
2012-01-14 18:26:48 [INFO] User CyberaX checked for "mcmmo.ability.mining", "*" found
2012-01-14 18:26:48 [INFO] User CyberaX checked for "mcmmo.ability.excavation", "*" found
2012-01-14 18:26:48 [INFO] User CyberaX checked for "mcmmo.ability.swords", "*" found
2012-01-14 18:26:48 [INFO] User CyberaX checked for "mcmmo.ability.unarmed", "*" found

-Keith