bhickey/TreeStructures — Issue #1: wrong term/implementation in Data.Heap.Binary and Data.Tree.Splay
Author: MaskRay
Created: 2012-01-14 05:04:19+00:00
State: open

I have taken a look at your project roughly and found something weird. The Data.Heap.Binary you implemented did not seem to be the `Binary heap' I learned from books. Its `merge' operation looked similar to Leftist tree and size balanced tree.

And in Data.Tree.Splay, you seemed to provide a top-down implementation of Splay trees, however, the lack of double rotates may not guarantee the O(log n) amortized time complexity.

--
Regards,
Ray Song