ipython/ipython — Issue #1248: IPython notebook doesn't work with lastest version of tornado
Author: bjedwards
Created: 2012-01-09 20:03:53+00:00
State: open

Tornado now supports the draft versions of websocket 7 and 8 as well as the final version 13. This resulted in a name change of `WebsocketProtocol8` to `WebsocketProtocol13`.

In commit :

https://github.com/facebook/tornado/commit/0a949c07be95a5c1b453f3e329d8a68a1280e873

This means a change is needed in `frontend/html/notebook/handlers.py` to change the call of `WebsocketProtocol8` to `WebsocketProtocol13`.

To maintain backwards compatibility we could either do a try/except, or check the tornado version. I am not sure which you guys prefer.