Exercise/FOQElasticaBundle — Issue #60: Exception handling
Author: richardmiller
Created: 2012-01-05 23:15:35+00:00
State: open

In the ObjectPersister whether exceptions are thrown or not is controlled by a class property that is hard coded to true. This needs to be settable or if we want it to always throw exceptions then the catching and checking this property can be removed.

In the Doctrine listeners there is checking for exceptions which are logged if there is a logger and just suppressed if there isn't. This does not fit in with the idea of letting exceptions escape the bundle unless the client is over ridden to catch them. If this is done then no exceptions should reach the listener anyway.

I think that all the exception handling in these classes should be removed as it can be handle in the overridden client. Likewise as logging is done in the client there is no need to do it in these classes. If it needs to be done here then it only needs to be done in the ObjectPersister and not the Doctrine listeners as well. @jmikola what do you think?