tombenner/front-end-users — Issue #1: PHP 5.4 Incompatibility (re-assigning auto global)
Author: tiernan
Created: 2012-01-04 02:22:15+00:00
State: open

/lib/front_end_users.php throws a fatal error in update_user_settings using PHP 5.4 (RC3/4) as shadowing auto globals is no longer supported. (lines 557-627)

Changing the function arguments name and its references from _POST fixes the issue. This is the only incompatibility I could find.

Currently:

public function update_user_settings(&$user, $_POST) {

if (empty($_POST)) {
return null;
}
...

Compatible version:

public function update_user_settings(&$user, $post) {

if (empty($post)) {
return null;
}
...

Thank you for the plugin.