njh/twolame — Issue #15: reserved identifier violation
Author: elfring
Created: 2012-01-04 14:03:34+00:00
State: open

I suggest to try the search pattern "\\<\_(?:(?:_(.*))|([A-Z]+))" on source files.
Some places will be found where names begin with two underscores or an underscore and an uppercase letter.

Examples:
- [```__TWOLAME_H__```](https://github.com/njh/twolame/blob/454ab65572eb6cd9ad1442788132e9fde410e169/libtwolame/twolame.h#L25)
- [```_COMMON_H```](https://github.com/njh/twolame/blob/12b52c8e74f26fef0d155d15ab1bd124a70934fd/libtwolame/common.h)
- [```_UTIL_H_```](https://github.com/njh/twolame/blob/454ab65572eb6cd9ad1442788132e9fde410e169/libtwolame/util.h#L26)

[This does not fit](https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not use identifiers that are reserved for the compiler implementation.") to the expected naming conventions of the C/C++ language standard.
I recommend to adjust your selection for unique names.