away3d/away3d-core-fp11 — Issue #201: SegmentSet Refactoring Invalid
Author: tcorbet
Created: 2012-01-03 02:24:39+00:00
State: open

Other than the addition of the formerly missing dispose() method, the 'external contract' of the SegmentSet Class has not changed. The user should expect, therefore, that no change will be required in whatever current use his application makes of that Class in the Master branch.

It does not appear that sufficient testing was performed to insure that that would be the case.

After an hour of testing, it looked to me like the problem must have to do with the changes of textures as materials. Since the SegmentMaterial Class was not touched, I went to the SegmentPass where, indeed, the changes are extensive. I do not have the knowledge to be able to debug/fix the problems. So, I reverted to the Master version of the Class -- only making the necessary changes in overriden methods to make SegmentPass conformant to the new API based on LightPicker logic.

While that probably will have other complications in other environments where enhanced light handling is envisioned, it is a valid fix to the current malfunctioning Dev version. The in-line notes indicate that SegmentPass has not really been redesigned/retested for the new API, so until it functions as a plug-in replacement for existing applications, I would recommend that a hacked version similar to mine be used as a placeholder so that existing applications can continue to be used with the Dev codebranch.