ivansafrin/Polycode — Issue #81: 4dc296959179 breaks Bindings build
Author: mcclure
Created: 2011-12-31 01:41:16+00:00
State: open

Tried to do a build of 4dc296959179 with minor patches and -DPOLYCODE_BUILD_BINDINGS=1. Build failed on the binding build step with this error

In file included from /home/mcc/work/p/Polycode/Bindings/Contents/LUA/Source/PolycodeLUA.cpp:2:0:
/home/mcc/work/p/Polycode/Bindings/Contents/LUA/Include/PolycodeLUAWrappers.h: In function ‘int Polycode::Polycore_ParticleEmitter(lua_State*)’:
/home/mcc/work/p/Polycode/Bindings/Contents/LUA/Include/PolycodeLUAWrappers.h:11108:166: error: cannot allocate an object of abstract type ‘Polycode::ParticleEmitter’
/home/mcc/work/p/Polycode/Core/Contents/Include/PolyParticleEmitter.h:49:20: note: because the following virtual functions are pure within ‘Polycode::ParticleEmitter’:
/home/mcc/work/p/Polycode/Core/Contents/Include/PolyParticleEmitter.h:54:17: note:	virtual void Polycode::ParticleEmitter::dispatchTriggerCompleteEvent()
/home/mcc/work/p/Polycode/Core/Contents/Include/PolyParticleEmitter.h:138:20: note:	virtual Polycode::Matrix4 Polycode::ParticleEmitter::getBaseMatrix()
make[2]: *** [Bindings/Contents/LUA/CMakeFiles/PolycodeLua.dir/Source/PolycodeLUA.cpp.o] Error 1

Both of the two virtual functions flagged here were added in the same commit

changeset: 295:b6de0ca63b1c
git-rev: 4dc296959179
parent: 291:1e5bd9f43290
user: Ivan Safrin
date: Sun Dec 25 17:37:04 2011 -0500files: Core/Contents/Include/PolyParticleEmitter.h Core/Contents/Source/Po
lyParticleEmitter.cpp
description:
Particle system tweaks

I tried a build against b92961be84cf ("Added collision point in world space to 2D physics"), again with minor patches, THIS build did not seem to run into this error (although it seems to have other problems which are my fault and which I am still working with).