dynamobi/dynamobi — Issue #525: [FRG-347] clean up how oracle tests are enabled in farrago's build.xml
Author: dynamobi-build
Created: 2011-12-30 03:33:21+00:00
State: open
Labels: FRG

[reporter="jhyde", created="Wed, 17 Sep 2008 09:30:45 -0500 (GMT-05:00)"]
Julian Hyde wrote:

> Change 11567 adds a test that creates a foreign server pointing at

> Oracle's scott/tiger schema and runs some queries on it.

>

> http://p4web.eigenbase.org/@md=d&c=6PU@/11567?ac=10

>

> Obviously we don't want to require that every testing machine has Oracle

> installed, so we do some jiggery-pokery. If ORACLE_HOME is set and

> ${ORACLE_HOME}/jdbc/lib/ojdbc14.jar is found, build.xml assumes that the

> database is on a particular URL and that the scott/tiger schema exists

> and is populated with the usual EMP and DEPT tables, then it runs the

> farrago/unitsql/med/scott.sql test. If not, scott.sql is ignored.

JVS:

I'd like to avoid conditional+automatic environmental dependencies like

this in "ant test"; they can cause too many mysteries. Could you change

it to require an explicit property setting in customBuild.properties, in

which case the dependency MUST exist, whereas by default the test just

won't run?

As Stephan noted in his reply, LucidDB test suites have some

heavier-duty infrastructure around foreign-DB-specific testing. If we

want to start adding a lot more of that at the Farrago level, let's plan

out at the next Eigenbase meeting what that means in terms of

infrastructure/dependencies and moving some of the LucidDB tests up to

Farrago level so that we don't duplicate effort.