dynamobi/dynamobi — Issue #414: [FNL-69] resolve code review comment for discardCachePage in SnapshotRandomAllocationSegment.cpp
Author: dynamobi-build
Created: 2011-12-30 03:12:52+00:00
State: open
Labels: FNL, Segment

[reporter="jvs", created="Thu, 25 Oct 2007 15:10:56 -0500 (GMT-05:00)"]
449a464,468

> > // REVIEW jvs 23-Oct-2007: this raises the question of whether

> > // discardCachePage should really be part of the Segment interface at all;

> > // seems like SegPageLock should instead rely on deallocatePageRange

> > // to do it implicitly.

This is doable, but if I do the discard implicitly in deallocatePageRange, then all segments that define that method will need to remember to do this. I can put the discard call into Segment::deallocatePageRange, but all segments that override the method will have to remember to call the base method.

-- Zelaine