hydrologics/Oasis.Base — Issue #60: Static members in partials should be, well, static
Author: johnmetta
Created: 2011-12-29 19:45:43+00:00
State: open

We need to clean up the code, and some low-hanging fruit would be to make stuff like [static info](https://github.com/hydrologics/Oasis.Base/issues/59) in the partials explicitly static. To wit: The Arc partial contains this:

```C#

public List DiscriminantProperties
{
get
{
return new List() { "Name", "UpstreamNumber", "DownstreamNumber" };
}
}

public List CompareProperties
{
get
{
return new List() { "Dummy", "Name", "UpstreamNumber", "DownstreamNumber",
"AWeight", "BWeight", "TotalWeight", "MaxRevFlow", "MinFlow"};
}
}
```
which is somewhat silly since this doesn't require instantiation and doesn't need to be a property at all. i.e.

```c#
public static List DiscriminantProperties = new List() { "Name", "UpstreamNumber", "DownstreamNumber" };
public static List CompareProperties = new List() { "Dummy", "Name", "UpstreamNumber",
"DownstreamNumber", "AWeight", "BWeight", "TotalWeight", "MaxRevFlow", "MinFlow"};
```

The first way means that every single Arc that's instantiated creates two new lists with those properties, which is just an unnecessary memory hog.