WebIDauth/WebIDauth — Issue #3: GET request parameters ignored by 3rd party software
Author: larjohn
Created: 2011-12-27 20:34:06+00:00
State: open

Hi there,

congrats for this great piece of software.

I am building a Drupal module that interacts with WebIDauth to authenticate users. The problem is in line 400 of WebIDauth.php:

$this->data = $this->issuer . "?webid=" . urlencode($webid) . "&ts=" . urlencode($this->ts);

Drupal uses to attach a ?q=... in the request uri. When WebID attaches its own ?webid, php cannot recognise the parts after the second as being GET parameters. So I suggest this line would better be

$this->data = $this->issuer . (strpos($this->issuer,'?')===false?"?":"&")."webid=" . urlencode($webid) . "&ts=" . urlencode($this->ts);

or something similar, in order to be attached with a '&' instead of '?'.

Thanks in advance,
Larry