RequestPolicy/requestpolicy — Issue #182: blocked redirects after link click can confuse menu
Author: jsamuel
Created: 2011-12-22 18:58:25+00:00
State: open
Labels: extension

imported trac ticket
created: 2011-02-06 10:34:41
reporter: justin

(This ticket may be inaccurate. I haven't found an easily repeatable example. Fundamentally there's a bug somewhere because of the broken menu entry, the rest is trying to piece together why. There may be some relationship with #176 as one user reported seeing an empty page when using "open in new tab" and this may be the redirect notification now showing.)

If one clicks a link from site A to site B and the page at site B attempts to redirect to site C, the menu can get confused. The menu on the original site A page may show site B listed as an allowed destination but there are no submenus available for the site B item.

This issue or something closely related to it may be known. I see RP logging the string "WARNING: other than the menu showing this blocked request, there is no other indication." in some cases and the RP service even notifies overlays through a call to `observeBlockedLinkClickRedirect`, which currently does nothing but log that warning.

The one example I have is this site (using hxxp because I'm not sure I want to be linking to these sites):

hxxp://kino.to/Stream/Family_Guy-3.html

From here, it's possible to get a broken menu if one opens some certain link in a new window. I think it has to do with blocked link click redirects. Here's a log snippet:

{{{
[RequestPolicy] [WARNING] [CONTENT] ** ALLOWED ** reason: User-initiated request by link click. type: 6, destination: hxxp://www.mystream.to/file-11100209-6bddaad3-Family.Guy.s01e01.Death.Has.a.Shadow.XviD_SChiZO.avi, origin: hxxp://kino.to/Stream/Family_Guy-3.html, context: [object XULElement], mime: , null
[RequestPolicy] [WARNING] [HEADER_REDIRECT] Observed blocked link click redirect from page with redirect origin and redirect dest . --- WARNING: other than the menu showing this blocked request, there is no other indication.
[RequestPolicy] [WARNING] [HEADER_REDIRECT] ** BLOCKED ** 'Location' header to found in response from
[RequestPolicy] [WARNING] [CONTENT] Allowing (but not recording) request where origin is the same as the destination: hxxp://www.mystream.to/file-11100209-6bddaad3-Family.Guy.s01e01.Death.Has.a.Shadow.XviD_SChiZO.avi
}}}

More discussion of this problem [http://forums.mozillazine.org/viewtopic.php?p=10380587#p10380587 here].

What this ticket really needs is a simple, repeatable test case.