addyosmani/backbone-fundamentals — Issue #11: Bunch of minor comments
Author: JustinDrake
Created: 2011-12-22 18:42:47+00:00
State: open

1) Consider expanding "qSA" for the new-comer.

2) "It's considered optional" -> it *is* optional?

3) "title = myPhoto.get("title")" -> too many spaces

4) "Accessing Model.attributes directly is fine for reading or cloning data, but ideally shouldn't be used to for attribute manipulation." -> Jeremy recommends not touching at Model.attributes at all. For reading or cloning data, he suggests toJSON.

5) "in scenario where" -> a word is missing

6) There are minor spacing consistency problems in the fragments of code throughout. For example "_.template( $("#results-template").html());"

7) In the "What is 'el'?" section you don't emphasize that you can use a *combination* of the methods to define el

8) "render() is a function that should always be overridden" -> render() is optional

That's all for now. Let me know if this is useful.