RequestPolicy/requestpolicy — Issue #122: request log context menu can be confusing
Author: jsamuel
Created: 2011-12-22 04:02:26+00:00
State: open
Labels: extension

When the request log is empty and shows the default text, the context menu still works. Trying to open origin/dest in a new tab gives the "that url can only be copied to the clipboard" message because it's using the text "The request log is initially empty" as the url.

Aleksej suggested that maybe the context menu entries shouldn't be active when the action is forbidden. That does make sense, and would enable a good way to solve this problem. The major reason this wasn't done initially is because it would have taken more time to fix #71 and the way the provided patch worked was better than nothing at all (and nothing at all was what I had done in the six months of that ticket being open).

I'm also inclined to think that the context menu should show you a shortened version of the url it refers to. If the request log is moving quickly, you can end up being uncertain which row the context menu is referring to. --- Note that showing you a url means either showing you a more complicated menu with both the origin and destination or having the context menu be related to the cell you clicked on, not the row you clicked on.