RequestPolicy/tractest — Issue #236: Logging of Would Have Been Blocked Requests in Allow All Requests override mode
Author: jsamuel
Created: 2011-12-22 02:48:39+00:00
State: open
Labels: extension

Logging of "would have been blocked, but all requests allowed" is deceptive at best:

{{{
// We always call this from shouldLoad to reject a request.
reject : function(reason, args) {
requestpolicy.mod.Logger.warning(requestpolicy.mod.Logger.TYPE_CONTENT,
"** BLOCKED ** reason: "
+ reason
+ ". "
+ this._argumentsToString(args[0], args[1], args[2], args[3],
args[4], args[5]));

if (this._blockingDisabled) {
return CP_OK;
}
}}}

This logs the request as "blocked", but then proceeds to allow it...