nose-devs/nose — Issue #304: No need for ErrorClassPlugin to keep original methods when monkey patching result
Author: jpellerin
Created: 2011-12-14 16:07:09+00:00
State: open

In nose.plugins.errorclass.ErrorClassPlugin.patchResult, we monkey patch a non-standard TestResult instance so that it emulates the error handling functionality of Nose's TextTestResult.

When we do this, we store the original methods on the result instance, named (for example) _orig_addError. We also have a couple of unit tests (in test_skip_plugin and test_deprecated_plugin) to verify that these original methods exist.

My question is, why do we do this? They do not appear to be used (apart from the unit tests), and creating them makes ErrorClassPlugin harder to understand.

Google Code Info:
Issue #: 472
Author: gazi...@gmail.com
Created On: 2011-11-24T06:57:02.000Z
Closed On: