facebook/hiphop-php — Issue #440: reserved identifier violation
Author: elfring
Created: 2011-12-11 16:40:45+00:00
State: open

I suggest to try the search pattern "\\<\_(?:(?:_(.*))|([A-Z]+))" on source files.
Some places will be found where names begin with two underscores or an underscore and an uppercase letter.

Examples:
- [```__HPHP_BASE_INCLUDES_H__```](https://github.com/facebook/hiphop-php/blob/e6c18b80e7158cd7f17057cdc33af670dd958fc0/src/runtime/base/base_includes.h#L17)
- [```__HPHP_PIPE_H__```](https://github.com/facebook/hiphop-php/blob/53ec28e4166667a53c5262f0176a1079b8362cfc/src/runtime/base/file/pipe.h#L17)
- [```_Null```](https://github.com/facebook/hiphop-php/blob/931e86546bee171ea17ba4cacfedb9cec712f841/src/util/json.h#L71)

[This does not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL32-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not use identifiers that are reserved for the compiler implementation.") to the expected naming conventions of the C/C++ language standard.
I recommend to adjust your selection for unique names.