iliaal/php_excel — Issue #19: possible issue in readRow
Author: pierrejoye
Created: 2011-12-02 10:49:39+00:00
State: open

hi Ilia,

..\pecl\php_excel\excel.c(2074) : warning C4244: '=' : conversion from 'long' to 'unsigned short', possible loss of data
..\pecl\php_excel\excel.c(2133) : warning C4244: '=' : conversion from 'long' to 'unsigned short', possible loss of data

not sure why you use unsigned short here while the function signature takes a signed integer:

static zend_bool php_excel_read_cell(int row, int col, zval *val, SheetHandle sheet, BookHandle book, FormatHandle *format)

and this variable is initialized using ling, could lead to some funny values :)