meskyanichi/backup — Issue #240: Manually removing old backups triggers failures
Author: yfeldblum
Created: 2011-12-02 14:15:53+00:00
State: open

If old backups are removed manually from storage, then when `Backup::Storage::CloudFiles#cycle!` tries to remove them but gets a `404 Not Found`, the backup run fails, triggering an overall failure including a failure notification.

If `#cycle!` gets a `404 Not Found`, that's a status code indicating the backup was already removed from storage manually. Backup may warn in this case, but it should not fail. Instead, it should take note of this particular condition, remove the record from its `Backup::Storage::Object` list of future backups to remove, and proceed with the rest of the backup run. The `404 Not Found` for attempting to remove an old backup is *not* an overall failure condition and it should not halt the remainder of the backup run.

Only `404 Not Found` should get this special handling; all other `4xx` and `5xx` response codes remain actual failures on the backup end or the storage end.