jslingerland/BluePay-Gateway — Issue #1: success? incorrectly returns true when declined
Author: tedkalaw
Created: 2011-11-30 02:51:38+00:00
State: open

Hi there,

I'm using this with ActiveMerchant, and success? appears to incorrectly return 'true' even if the transaction is declined. This can be reproduced by submitting an even number of dollars and examining the response object.

The cause for this is that $rebill_result will be an empty string if a successful, non-rebilled transaction made - as such, success? will ALWAYS return true.

I haven't played with rebilling yet and I don't want to break anything, so once I take a second look, I'll try to fix it.