saltstack/salt — Issue #288: salt '*' state.highstate should provide more failure information for nodes that fail
Author: mdfranz
Created: 2011-11-27 17:35:44+00:00
State: open

For example, we get nothing from optibsd on the master

---
----
root@salt-master:~# salt '*' state.highstate
optibsd.blah.com:
localhost:
----------
State: - file
Name: /etc/environment
Function: managed
Result: True
Comment: File /etc/environment is in the correct state
Changes:
----------
State: - pkg
Name: nmap
Function: installed
Result: True
Comment: Package nmap is already installed
Changes:
----------
State: - file
Name: /etc/resolv.conf
Function: managed
Result: True
Comment: File /etc/resolv.conf is in the correct state
Changes:
----------
State: - pkg
Name: tcpdump
Function: installed
Result: True
Comment: Package tcpdump is already installed
Changes:
----------
State: - pkg
Name: xprobe
Function: installed
Result: True
Comment: Package xprobe is already installed
Changes:

----
optibsd# salt-call state.highstate
12:09:21,549 [salt.state ][INFO ] Executing state file.managed for /etc/environment
Traceback (most recent call last):
File "/usr/local/bin/salt-call", line 17, in
main()
File "/usr/local/bin/salt-call", line 14, in main
client.run()
File "/usr/local/lib/python2.6/site-packages/salt/cli/__init__.py", line 561, in run
caller.run()
File "/usr/local/lib/python2.6/site-packages/salt/cli/caller.py", line 71, in run
ret = self.call()
File "/usr/local/lib/python2.6/site-packages/salt/cli/caller.py", line 34, in call
*self.opts['arg']
File "/usr/local/lib/python2.6/site-packages/salt/modules/state.py", line 64, in highstate
return st_.call_highstate()
File "/usr/local/lib/python2.6/site-packages/salt/state.py", line 679, in call_highstate
return self.state.call_high(high)
File "/usr/local/lib/python2.6/site-packages/salt/state.py", line 505, in call_high
return self.call_chunks(chunks)
File "/usr/local/lib/python2.6/site-packages/salt/state.py", line 370, in call_chunks
running = self.call_chunk(low, running, chunks)
File "/usr/local/lib/python2.6/site-packages/salt/state.py", line 482, in call_chunk
running[tag] = self.call(low)
File "/usr/local/lib/python2.6/site-packages/salt/state.py", line 359, in call
ret = self.states[cdata['full']](*cdata['args'])
File "/usr/local/lib/python2.6/site-packages/salt/states/file.py", line 398, in managed
shutil.copy(sfn, name)
File "/usr/local/lib/python2.6/shutil.py", line 84, in copy
copyfile(src, dst)
File "/usr/local/lib/python2.6/shutil.py", line 50, in copyfile
with open(src, 'rb') as fsrc:
IOError: [Errno 2] No such file or directory: ''