Toubib/check-webpage — Issue #13: "Pull request" for f8b02047c561 and aad130fb5a5f
Author: ctheune
Created: 2011-11-25 16:23:56+00:00
State: open

I made a couple of improvements to the code (also on your recent bugfix)
but I didn't notice that you moved the project to github already.

I'm maintaining my changes in Mercurial and here's a branch where I added a new feature and some smaller fixes:
https://bitbucket.org/ctheune/check_webpage.rb-gocept/changesets

I'd love if you could have a look at the patches f8b02047c561 and aad130fb5a5f.

Changes:
- allow storing the output of the main page if we say the result is critical
- parse and leverage the base tag if existent
- improve the relative URL resolution code by leveraging URI.merge

Disclaimer: I'm used to Python not Ruby so my patch might be awful. I also didn't add any tests (me bad). If you're interested in the changes and want me to improve them, I'd be happy if you gave me pointers.