antirez/redis — Issue #211: reserved identifier violation
Author: elfring
Created: 2011-11-25 17:50:07+00:00
State: open

I suggest to try the search pattern "\\<\_(?:(?:_(.*))|([A-Z]+))" on source files.
Some places will be found where names begin with two underscores or an underscore and an uppercase letter.

Examples:
- [```__ADLIST_H__```](https://github.com/antirez/redis/blob/e2641e09cc0daf44f63f654230f72d22acf3a9af/src/adlist.h#L31)
- [```__DICT_H```](https://github.com/antirez/redis/blob/14ed10d9573b57c43011c2af2f5abb771abc7bfb/src/dict.h#L38)
- [```__xstr```](https://github.com/antirez/redis/blob/650463401999f675ae4254790db13aac5ddc5c5b/src/zmalloc.h#L35)

[This does not fit](https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29"Do not use identifiers that are reserved for the compiler implementation.") to the expected naming conventions of the C language standard.
I recommend to adjust your selection for unique names.