mangos/mangos — Issue #25: Wrong index usage
Author: Blumster
Created: 2011-11-24 10:30:57+00:00
State: open

There is a typo int he commit: 3175561925d3bb39e0a8489e6181e0fe4acb4a68
( [11610] Select proper spell difficulty subtitution. )

This part of the code: (SpellMgr.cpp, Line 4508-4509)

if (spellDiff->spellId[diff])
return sSpellStore.LookupEntry(spellDiff->spellId[difficulty]);

shouldn't be

if (spellDiff->spellId[diff])
return sSpellStore.LookupEntry(spellDiff->spellId[diff]);

TBH, I think this is unnecessary. You can't enter Ulduar in 25man hc, so you can't get 0 as spellid from DBC.
If the map returns, that It's 25 man hc, there should be a 25man hc type of the spell, or it shouldn't be casted.