TrinityCore/TrinityCore — Issue #4058: reserved identifier violation
Author: elfring
Created: 2011-11-24 18:49:07+00:00
State: open

I suggest to try the search pattern "\\<\_(?:(?:_(.*))|([A-Z]+))" on source files.
Some places will be found where names begin with two underscores or an underscore and an uppercase letter.

Examples:
- [_StartDB](https://github.com/TrinityCore/TrinityCore/blob/bd85914d92ccab255475dce9d4700abdc8428fb4/src/server/worldserver/Master.h#L37)
- [_PLAYER_DUMP_H](https://github.com/TrinityCore/TrinityCore/blob/bcd7e45e1227741a38001423d9a713e6614edd3f/src/server/game/Tools/PlayerDump.h#L19)
- [_VMAPDEFINITIONS_H](https://github.com/TrinityCore/TrinityCore/blob/af05915b9e36497eda8f2f061c29ffee0c8042b6/src/server/collision/VMapDefinitions.h#L19)

[This does not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL32-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not use identifiers that are reserved for the compiler implementation.") to the expected naming conventions of the C/C++ language standard.
I recommend to adjust your selection for unique names.