extend/cowboy — Issue #92: Don't depend on external "quoted.erl" urlencoded parser
Author: csrl
Created: 2011-11-22 06:21:56+00:00
State: open

The following locations use the external quoted.erl library:

src/cowboy_dispatcher.erl:67:	[quoted:from_url(Token) || Token <- EncodedPath].
src/cowboy_http_req.erl:456:	[Token] -> {quoted:from_url(Token), true};
src/cowboy_http_req.erl:457:	[Name, Value] -> {quoted:from_url(Name), quoted:from_url(Value)}

External dependencies make it more difficult to integrate cowboy into existing applications. In particular, this quoted library uses a NIF implementation, and while a non-NIF implementation also exists in the library, it takes some manual manipulation to use it - the concept being here not wanting to use a NIF dependency either.

So, I'm bringing this up to see what the mind set is behind the use of the quoted.erl library. I'd expect a native parser in cowboy - http handling is a major part of cowboy, it is odd that this aspect is outsourced... So does the roadmap include implementing this, and would a patch be rejected? If not could that patch just be the quoted.erl erlang module copied over with appropriate adjustments?