cschiewek/devise_ldap_authenticatable — Issue #60: Update for testing on 1.9.x and on non-OSX machines
Author: anithri
Created: 2011-11-21 19:10:42+00:00
State: open

So I'm trying to update to devise ~>1.5.0 and so I thought I'd clone the repo, make the changes, run the tests and submit a pull request for the change.

Then i entered dependency hell. Using Ubuntu I'm having problems getting the specific version of gherkin to compile, and rbx-require-relative isn't needed for 1.9.x rubies. I use the gem just fine with 1.9.3 on Ubuntu.

Getting it to run for me is going to mean updating the Gemfile.lock in test/rails_app so I can install tools that actually work on Ubuntu. And I'm more than a little afraid of going through that work to find the tests not passing because there's other hidden gotchas when I'm not testing using REE and OSX.

I don't mind doing the work, but wanted to check in and see if you had any concerns with me making those kind of changes. I'm a very long way from being an expert in TDD, but I'm also trying to jump in contribute more to the gems I use.