WedgeCoop/IS4C — Issue #11: Possible buffer overrun in ssd.c? 
Author: tmmagee
Created: 2011-11-20 16:42:44+00:00
State: open

In ssd.c the scannerInput array is defined as follows:

char scannerInput[12];

But later in the code when the scanner input is read:

for (i = 0; i < 17; i++) {
scannerInput[i] = serialBuffer[i+4];
}

Is this buffer overrun intentional? I have seen this code in multiple is4c forks on github and it has not been corrected. I changed the size of scannerInput to 17 in my own code to correct the issue, and the daemon still appears to run fine. Is there something I am missing?