libgit2/libgit2 — Issue #487: 3 of the 31 headers in include/git2 have a different #include strategy
Author: brianhill
Created: 2011-11-17 20:22:53+00:00
State: open

28 of the files in include/git2 do their includes as follows:

#include "common.h"
#include "types.h"

That example is from oid.h. Note there is no git/ in the include.

However, 3 files put an extra git/ in the includes. Those are indexer.h, refspec.h and remote.h.

For example, refspec.h includes types.h as follows:

#include "git2/types.h"

Unless there is a good reason for the inconsistency, it would be good to remove the the extra git/ in the three files that have them, because it causes dependent projects to have to put extra include paths into their builds.