paddybyers/node — Issue #19: gyp build issues on xcode
Author: paddybyers
Created: 2011-11-16 00:01:08+00:00
State: open

So here's my first attempt at this:

https://github.com/paddybyers/node/commits/gyp-xcode

Two issues:

1) node-v8.gyp includes v8.gyp (which is, as intended, unmodified from the file in v8 upstream).

However, gyp goes wrong when files included in this way have a ".gyp" extension. renaming it ".gypi" resolves this. There should be a better way that removes the need for node-v8 altogether.

2) the xcode generator is attempting to generate a "FrameworksPhase" for targets that do not themselves generate any binaries; in this case, the node_j2sc target.

In fact it only goes wrong because there is a library defined - `-lz` - which is inherited from the global target default that is set up by configure. If this was not added by configure, but was added explicitly for the node executable target instead, then this problem would not appear. This is why v8 does not fall over the same problem even though it has similar js2c targets.

Nonetheless, I'm inclined to think it's a gyp/xcode bug, so the fix is in there.