charlotte-ruby/impressionist — Issue #14: Impressions table should use text rather than string
Author: coryschires
Created: 2011-11-15 20:02:05+00:00
State: open

You should update the migrations to change the following columns to text rather than string:

request_hash, session_hash, message, referrer

This is actually a *really big problem*. Specifically the `referrer` column. When searching from Google, the http referrer is very often over 255 characters which means any page using this gem will throw 500 errors when people try to visit from Google. That's no good. Especially because there's really no way to anticipate the problem until the code is in production.

I don't mind making a pull request, but it's an obvious fix, and I'm not sure how you want to do it (i.e. a new migration or amending the existing one). That said, if a pull request would be helpful, let me know and I'll take care of it.