petdance/scratch — Issue #748: [CAGE] Fixed a few warnings and a NCI example on Windows using MSVS
Author: petdance
Created: 2011-11-14 06:13:22+00:00
State: open
Labels: cage, configure, Pri-normal, Sev-medium

Fixed '''warnings''' like unused variables, unreachable code in core.ops[[BR]]
config/gen/platform/win32/exec.c[[BR]]
config/gen/platform/win32/stat.c[[BR]]
include/parrot/encoding.h[[BR]]
src/embed.c[[BR]]
src/oo.c[[BR]]
src/ops/core.ops[[BR]]
src/packfile.c[[BR]]
src/spf_render.c[[BR]]
src/string/encoding.c[[BR]]
src/string/encoding/fixed_8.c[[BR]]
src/thread.c[[BR]]

also Fixed a '''NCI example'''[[BR]]
examples/nci/PQt.C[[BR]]
examples/nci/PQt.cpp[[BR]]
examples/nci/QtHelloWorld.pasm[[BR]]
examples/nci/QtHelloWorld.pir [[BR]]

this is a good way to get comfortable with code base :)[[BR]]

```
CREDITS | 2
config/gen/platform/win32/exec.c | 3
config/gen/platform/win32/stat.c | 3
examples/nci/PQt.C | 149 --------------------------------------
examples/nci/PQt.cpp | 151 +++++++++++++++++++++++++++++++++++++++
examples/nci/QtHelloWorld.pasm | 22 ++---
examples/nci/QtHelloWorld.pir | 69 +++++++++++++++++
include/parrot/encoding.h | 8 +-
src/embed.c | 2
src/oo.c | 2
src/ops/core.ops | 13 ++-
src/packfile.c | 2
src/spf_render.c | 3
src/string/encoding.c | 10 ++
src/string/encoding/fixed_8.c | 8 +-
src/thread.c | 6 +
16 files changed, 275 insertions(+), 178 deletions(-)
```

```
:
[FIXED]src\ops\core_ops.c
[FIXED]src\ops\core.ops(920) : warning C4189: 'resume' : local variable is initialized but not referenced
[FIXED]src\ops\core.ops(920) : warning C4189: 'resume' : local variable is initialized but not referenced
[FIXED]src\ops\core.ops(920) : warning C4189: 'resume' : local variable is initialized but not referenced
[FIXED]src\ops\core.ops(920) : warning C4189: 'resume' : local variable is initialized but not referenced
:
[NOT FIXED]src\ops\experimental.ops(52) : warning C4189: 'unused' : local variable is initialized but not referenced
:
:
[FIXED]f:\git\rakudo\parrot\src\ops\core.ops(1453) : warning C4702: unreachable code
[FIXED]f:\git\rakudo\parrot\src\ops\core.ops(1472) : warning C4702: unreachable code
[FIXED]f:\git\rakudo\parrot\src\ops\core.ops(1472) : warning C4702: unreachable code
src\ops\core_ops_switch.c
[FIXED]src\ops\core.ops(920) : warning C4189: 'resume' : local variable is initialized but not referenced
[FIXED]src\ops\core.ops(920) : warning C4189: 'resume' : local variable is initialized but not referenced
[FIXED]src\ops\core.ops(920) : warning C4189: 'resume' : local variable is initialized but not referenced
[FIXED]src\ops\core.ops(920) : warning C4189: 'resume' : local variable is initialized but not referenced
:
[FIXED]src\embed.c(1296) : warning C4189: 'pf' : local variable is initialized but not referenced
[FIXED]src\string\encoding.c
[FIXED]src\string\encoding.c(156) : warning C4646: function declared with __declspec(noreturn) has non-void return type
[FIXED]src\string\encoding.c(445) : warning C4646: function declared with __declspec(noreturn) has non-void return type
:
:
[FIXED]src\packfile.c(868) : warning C4189: 'pf' : local variable is initialized but not referenced
:
[FIXED]src\spf_render.c
[FIXED]src\spf_render.c(115) : warning C4005: 'snprintf' : macro redefinition
[FIXED]F:\git\rakudo\parrot\include\parrot/misc.h(28) : see previous definition of 'snprintf'
:
:
[FIXED]config/gen/platform/win32/stat.c(115) : warning C4244: '=' : conversion from 'time_t' to 'INTVAL', possible loss of data
[FIXED]config/gen/platform/win32/stat.c(118) : warning C4244: '=' : conversion from 'time_t' to 'INTVAL', possible loss of data
[FIXED]config/gen/platform/win32/stat.c(121) : warning C4244: '=' : conversion from 'time_t' to 'INTVAL', possible loss of data
[FIXED]config/gen/platform/win32/exec.c(218) : warning C4090: 'function' : different 'const' qualifiers
src\pmc_freeze.c
f:\git\rakudo\parrot\src\pmc_freeze.c(1725) : warning C4706: assignment within conditional expression
:
:
[FIXED]src\thread.c
[FIXED]f:\git\rakudo\parrot\src\thread.c(639) : warning C4701: potentially uninitialized local variable 'val_sub' used
[FIXED]f:\git\rakudo\parrot\src\thread.c(503) : warning C4700: uninitialized local variable 'interp' used
:
:
[FIXED]src\string\encoding\fixed_8.c
[FIXED]src\string\encoding\fixed_8.c(236) : warning C4646: function declared with __declspec(noreturn) has non-void return type
:

```

Originally http://trac.parrot.org/parrot/ticket/446 by @ujwal