zikula-modules/News — Issue #14: Rename of links.searchtopic and other legacy names/functionality
Author: espaan
Created: 2011-11-07 10:03:00+00:00
State: open
Labels: Task

Reported by: espaan Owned by: mateo
Priority: minor Milestone: 3.1.0
Component: Basic News Module Version: News 2.2
Keywords: searchtopic Cc:
Status: pending-review

Description ¶
In getArticleLinks the searchtopic variable is filled with the url to search articles for a specific topic.
However in getArticleInfo the topic related fields are all named topicFIELDNAME.
IMO it is better to make that consistent and rename the searchtopic to topicsearchurl (or something resembling that one ;-))

This would have to be changed in a lot of places in the code and in the templates. It might be part of a bigger cleanup of the code.

Change History
comment:1 Changed 3 years ago by espaan
■Version set to Zikula 1.1 / News 2.2
■Milestone changed from Zikula 1.1 to 2.4
comment:2 Changed 3 years ago by mateo
yeah
we can do that cleanup for 2.5 and a major clean of the customized templates will be required here then
with a clear Wiki page of the changes made to facilitate the upgrade of old stuff ;-)
there are lots of details to change!
i don't like some legacy things :-P

comment:3 Changed 3 years ago by espaan
■Summary changed from Rename of links.searchtopic to Rename of links.searchtopic and other legacy names/functionality
Ok let's do that upgrade stuff for 2.5. Get rid of legacy names and some vars and make that more category proof :-)

There are a lot of things of course:

•topicname, topicimage
•/images/topics, see also #37
•topic_image category attribute, during upgrade 2.4 - 2.5 this should be renamed to catimage/categoryimage. In #37 i will add the module var catimagepath which should be used here as well.
Indeed a good upgrade explanation is needed.

comment:4 Changed 2 years ago by espaan
■Type changed from defect to task
comment:5 Changed 22 months ago by espaan
■Milestone changed from 2.5 to 2.6
comment:6 Changed 12 months ago by espaan
■Milestone changed from 2.7 to 3.0.0
Milestone 2.7 deleted

comment:7 Changed 4 months ago by craigh
■Milestone changed from 3.0.0 to 3.1.0
■Status set to pending-review