smartinez87/exception_notification — Issue #32: Background notifications could be DRYer and more complete
Author: jjb
Created: 2011-11-04 03:13:01+00:00
State: open

Hi — thanks for reviving this project!

So I'm potentially migrating away from Exceptional, which has `Exceptional::Catcher.handle_with_controller` and `Exceptional.handle`, which are analogs to `ExceptionNotifier::Notifier.exception_notification` and `ExceptionNotifier::Notifier.background_exception_notification `.

a few things about `ExceptionNotifier::Notifier.background_exception_notification`

1. it's sort of a second class citizen — it doesn't allow for custom templates
2. it has repeated code from `ExceptionNotifier::Notifier.exception_notification`
3. it's the only thing that can be appropriately used in a model (right?), so it's sort of misnamed

Maybe I'm wrong on 3, and I should just be using `ExceptionNotifier::Notifier.exception_notification` with an empty environment hash?

Let me know what you think — I'd be interested in cleaning it up, so that there is some sort of common method that is called in all contexts, doesn't repeat code, and reuses the templates.