pandaproject/panda — Issue #105: download data link actual href not js event
Author: springmeyer
Created: 2011-11-04 17:23:44+00:00
State: open

From a narrow minded developer perspective thinking about integrating with panda... backbone is awesome, but for something like the download link it seems friendlier to make the link a standard href rather than a js event. This makes it easy to hover and see the link and then easy to ctrl-click and copy the link.

```diff

diff --git a/README.rst b/README.rst
index 02e7b09..78514b2 100644
--- a/README.rst
+++ b/README.rst
@@ -40,7 +40,7 @@ This will setup the complete application, *except* for Solr::
python manage.py celeryd

# Open another terminal
- workon panda
+ cd panda
python manage.py runserver

**Setup Solr**
diff --git a/forest/static/js/models/uploads.js b/forest/static/js/models/uploads.js
index 5dc2065..a129698 100644
--- a/forest/static/js/models/uploads.js
+++ b/forest/static/js/models/uploads.js
@@ -5,7 +5,7 @@ PANDA.models.Upload = Backbone.Model.extend({
urlRoot: PANDA.API + "/upload",

download: function() {
- window.location = this.url() + "download";
+ //window.location = this.url() + "download";
}
});

diff --git a/forest/static/templates/edit_dataset.jst b/forest/static/templates/edit_dataset.jst
index 066bea6..4cc0175 100644
--- a/forest/static/templates/edit_dataset.jst
+++ b/forest/static/templates/edit_dataset.jst
@@ -18,7 +18,7 @@

Filename

-

<%= data_upload.original_filename %>

+

<%= data_upload.original_filename %>

diff --git a/setup_panda.sh b/setup_panda.sh
old mode 100644
new mode 100755
```