DNH-Computing/Stripes — Issue #5: (STS-785) Add "event" for subclasses of OnwardResolution
Author: danielhodder
Created: 2011-11-01 06:12:26+00:00
State: open

http://www.stripesframework.org/jira/browse/STS-785

When attempting to create things like LocalizedRedirectResolution one subclasses RedirectResolution

However in: net.sourceforge.stripes.action.OnwardResolution
We have:
private static final String VALUE_NOT_SET = "VALUE_NOT_SET";
private String path;
private String event = VALUE_NOT_SET;
private Map parameters = new HashMap();
private String anchor;

Problem #1:
----------------
path, anchor, and parameters have public getters/setters however 'event' attribute does not?

REQUEST: Please add public getters/setters for event
NOTE: One could make the above things protected to be accessible in subclasses but I suggest public as it is in-line with how the rest of the class is written.

Problem #2:
----------------
Having public access to to 'event' is great but one needs to be able to compare to see if the value is not set however the following is private:
private static final String VALUE_NOT_SET = "VALUE_NOT_SET";

REQUEST: Please make the above static at least protected vs. private so as to be able to compare within subclasses.

This is a really trivial request that makes the class more consistent.

--Nikolaos