andymatuschak/Sparkle — Issue #111: Sparkle won't build due to -Werror with -Wformat=2 and missing newlines
Author: danwood
Created: 2011-10-29 00:41:36+00:00
State: open

The current master of Sparkle has

-Werror
and
-Wformat=2

set int ConfigCommon.xcconfig.

Unfortunately, this means that Sparkle won't build - at least, in release, using Xcode 3.x in Snow Leopard.

-Werror makes all warnings into errors, and there are two warnings happening - one, that there a file with a missing newline at the end. The other ones, happning due to the -Wformat=2, are lots of warnings about "format not a string literal, argument types not checked" ... This is due to -Wformat=2 including -Wformat-nonliteral, which seems to have problems with the SULocalizedString macros.

Can we take out the -Wformat=2, and fix the missing newline issue?