greasemonkey/greasemonkey — Issue #1458: Refactor ScriptDownloader
Author: arantius
Created: 2011-10-28 20:08:22+00:00
State: open

I've noticed (mostly) recently that ScriptDownloader has grown poorly as we've increased the number of ways it's used:

* Only viewing a remote script (before installation)
* Installing an entire, new, remote script (including all dependencies)
* Updating a locally modified script (possibly loading dependencies)
* Updating a remotely modified script (thanks to update checking)

Especially, some of the method names are making less sense, now that more than one kind of updating is being done. In light of #1419 and #1156, I believe it's time to tackle this problem.