substack/node-browserify — Issue #87: Object.keys shim is inadequate
Author: humanchimp
Created: 2011-10-27 22:02:26+00:00
State: open

Hi there —

I noticed that the Object.keys shim used by browserify has an unfiltered for-in loop, meaning that it is not compatible with the standard method, which returns only the keys of the object's own properties. I was going to fix it and offer a pull request, but then it occurred to me that the fix would require a shim for Object.prototype.hasOwnProperty, and so I decided to tell you guys about it instead, and maybe after some discussion we can fix it.

https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Object/keys

Regards,
Chris