andymatuschak/Sparkle — Issue #109: Error extracting dmg archives
Author: berbie
Created: 2011-10-26 06:50:15+00:00
State: open

I have a side effect on the NSFileManager::copyItemAtPath:toPath:error: change above.
My binary is being distributed as a .dmg and does not only contain the .app but also a ReadMe.
SUDiskImageUnarchiver::extractDMG fails with an error because it cannot copy the mountPoint using NSFileManager::copyItemAtPath
I patched this by iterating over the contained files in mountPoint and copying only files with an .app extension.
I am not sure why this ever worked in the previous FSCopyObjectSync implementation.

My proposal would be this single patch: http://dl.dropbox.com/u/1963886/201111-Sparkle.zip

As a sidenote: in addition the error returned from NSFileManager::copyItemAtPath:toPath:error: is not being logged, which did cost me a while to nail down the problem in the framework.