mapbox/millstone — Issue #25: avoid creating an empty database when sqlite introspection fails
Author: springmeyer
Created: 2011-10-24 01:39:23+00:00
State: open

Millstone does some intense introspection of sqlite databases to be able to autodetect primary keys and spatialite geometry type.

When a user in tilemill miss spells a database, the logic fails but leaves behind a blank database (because the default behavior of node-sqlite3 is to create one if the filename passed does not exist).

This then creates very hard to understand errors when this db name is passed to node-mapnik/mapnik in TileMill which indicate the table is missing when really the database filename is wrong.

Because Mapnik latest upstream now can handle auto-detection of primary keys and spatialite geometry types I propose simply removing all this logic (rather than fixing the create if not found behavior). So, assigning to myself to get this cleaned up.