andymatuschak/TestMigration — Issue #20: SUPackageInstaller should respect synchronously option
Author: andymatuschak
Created: 2011-10-23 16:34:06+00:00
State: open

***David Dauer (ddauer)** [reported (on Launchpad)](https://bugs.launchpad.net/sparkle/+bug/301640) on' 2008-11-24:*

1.5b6:

the corrected method should be

+ (void)performInstallationWithPath:(NSString *)path host:(SUHost *)host delegate:delegate synchronously:(BOOL)synchronously versionComparator:(id )comparator;
{
....

NSTask *installer = [NSTask launchedTaskWithLaunchPath:installerPath arguments:[NSArray arrayWithObjects:path, nil]];
if (synchronously) [installer waitUntilExit]; // changed here

// Known bug: if the installation fails or is canceled, Sparkle goes ahead and restarts, thinking everything is fine.
[self _finishInstallationWithResult:result host:host error:error delegate:delegate];
}