fpoirotte/Erebot_buildbot — Issue #1: Use SetPropertiesFromEnv to figure proper PATH
Author: fpoirotte
Created: 2011-10-23 12:29:13+00:00
State: open

A few steps rely on certain PHP tools being available in the slave's `PATH`.
For now, this is achieved by setting the `bin_dir` property in _secrets.py_ to a series of paths to add to `PATH` when needed.

This is far from ideal as it propagates the issue from the slaves to the buildmaster. Instead, each slave should be responsible for its own configuration.

I think an appropriate solution is to require all slaves add a `BUILDBOT_PATH` variable (or maybe `EREBOT_PATH` ?) to its environment. Then, the buildmaster can use the `SetPropertiesFromEnv` step (as part of the "common" steps) to import that variable into the properties. Thus, all steps that set the `PATH` to `properties.WithProperties("%(bin_dir)s:${PATH}")` need only replace `bin_dir` with `BUILDBOT_PATH`

**Note**: `SetPropertiesFromEnv` requires the slave use at least Buildbot 0.8.3, which isn't such a big deal because this is already the case (some even use 0.8.4, eg. the Windows slave).