rdallasgray/roto — Issue #3: Descendant li's
Author: christopherdebeer
Created: 2011-10-20 09:38:40+00:00
State: open

Hey, just before i submit a pull request, I'd like to find out your thoughts and reasoning behind some of the things in jquery.roto.js.

You require that `$(container).roto()` be called on a containing element (within which you assume there to be a `

`) - is there a specific reason for this, as apposed to say calling roto() on the list itself? ie: `$(ul || ol || container ).roto();` within which we could assume nothing beyond that it will have children. - what are your thoughts?

This would allow it to work on say a `

` or `

` or just a `

` with child `

`s etc etc.

Also (part of my initial amend which you emailed me about), was to limit roto() to the Direct descendant li's, such that it wouldnt affect content within the li's (which allows me to have html content within my list - much like pages), so changing:

`listItems = ul.find("li")` to `listItems = container.find("ul > li")`

I'd like to hear your thoughts before I submit a pull request that might not fit with either your percieved use-cases or vision for/of jquery.roto.js

chris