LearningRegistry/LearningRegistry — Issue #112: Obtain & Harvest: request_ID argument case mismatched.
Author: kmentor
Created: 2011-10-19 22:00:12+00:00
State: open

#### Related Bugs:

#97 Changed request_ID to request_id to match spec
#82 harvest/getrecords request_ID paramater capitalization doesn't match spec
#85 Harvest/GetRecord - Returns OK for invalid request IDs.
#83 fix for issue #82

#### Description:
The argument "request_ID" appears to still have an error. The related bugs, listed above, are all in reference to the different implementation of the argument in regards to Obtain and Harvest. One is using "request_ID" while the other is using "request_id".

In reviewing both I find that they remain mismatched after bug fixes were checked in. Examples below.

Could this be due their descriptions in the Spec? Consider this from the Spec:

API
GET /harvest/getrecord?request_id=
&by_doc_ID=
&by_resource_ID=

Arguments (GET)
"request_ID":	ID,
"by_doc_ID":	bool
"by_resource_ID":	bool

If one were to use the API description they would implement "request_id". If they were instead to implement what is in the Argument section they would use "request_ID". This is true for Obtain as well. The value of "request_ID" is the only one that differs from the API section to the Arguments section which may be the cause of this bug continuing one way or the other.

#### Examples:
obtain?request_ID=1234&by_doc_ID=true
--Returns multiple docs

obtain?request_id=1234&by_doc_ID=true
--Returns the single doc.

harvest/getrecord?request_ID=1234&by_doc_ID=true"
--Returns the single doc.

harvest/getrecord?request_id=1234&by_doc_ID=true"
--Returns {"request": {"HTTP_request": "", "verb": "getrecord"}, "OK": false, "responseDate": "2011-10-19T21:16:43.467918Z", "error": "badArgument"}