paddycarey/script.extrafanartdownloader — Issue #23: Issues to resolve before pull request accepted
Author: paddycarey
Created: 2011-10-19 08:33:13+00:00
State: open

Emailed the addons mailing list this morning to double check before submitting the PR and got the following answers from spiff.

On Wed, Oct 19, 2011 at 10:24 AM, Patrick Carey wrote:
> Hi,
>
> I'm just about to submit a pull request for script.extrafanartdownloader
> but I wanted to check a few things beforehand. We've completely
> overhauled the addon and now have one combined branch that works on both
> Dharma and Eden, is this allowed or do we have to have separate
> branches?

no pulls of xbmc.python 1.0 in the eden branch.

> Also, we are currently using a local copy of elementtree as this
> simplifies working across different xbmc versions for us. Is this ok or
> must we use the xbmc supplied version?

available script modules must be utilized. is it a version problem?