infochimps/icss — Issue #11: :catalog_root load is brittle
Author: dsnyder90
Created: 2011-10-19 17:13:29+00:00
State: open

Settings.define :catalog_root, :type => :filename, :default => (defined?(Rails) ? (Rails.root+'catalog') : File.expand_path('../../infochimps_catalog', __FILE__))

This is ridiculous. If we're going to commit to core_types their location and version to be consistent and reliable. Requiring them isn't just a 'bonus', the whole thing crashes and burns without them. You've hotfixed this so it will work on your laptop and for infochimps_explorer, that's the extent of its portability.

Quick, tell me what version of the core_types George is using? Troop is using? Infochimps_explorer is using? Cornelius is using (soon)? Ingestion is using (soon)?

Core types need to be at the least, a pegged submodule of ICSS lib. When I need to read an ICSS, there should be NO external dependencies. This lib is peppered throughout our infrastructure in various states and inherent to the functionality of george, apeyeye, infochimps_explorer, troop, among others, and therefore every bit of it needs to be rock solid.