paddybyers/node — Issue #4: nameser include handling
Author: paddybyers
Created: 2011-10-19 14:26:49+00:00
State: open

There are two interrelated issues:

1) There is a lot of include logic relating to inclusion of nameser.h and the arpa variants that is duplicated across multiple files. Any change in the logic - in particular, and change that makes the logic more complex - makes the core progressively less maintainable.

2) There is an implicit assumption in the existing logic that any platform with HAVE_ARPA_NAMESER_H also has HAVE_ARPA_NAMESER_COMPAT_H, and this isn't true on Android (it has nameser.h only).

The suggested fix is to move all of that inclusion logic into one include file, and to adjust the logic to accommodate the Android case.

Proposed changes:

https://github.com/paddybyers/node/commit/dd60885b769f483c121dfad6577b80aeb0aea8b8
https://github.com/paddybyers/node/commit/e30dad0fbeba09fcc3b5feb5533471c7fcc9a420
https://github.com/paddybyers/node/commit/99e081c8630af24c3d1ecbedbc84c698a9ccfe0f