ooyala/barkeep — Issue #142: Disapprovals/issues should require issue-opener's approval
Author: noahgibbs
Created: 2011-10-18 21:11:27+00:00
State: open

Over lunch, several of us talked about a corner case that Barkeep could help with.

If a commit is approved, then disapproved because of three various problems with it, and two of those are fixed with commits, it's easy for somebody else to wander by and say "oh, hey, I see commits fixing these problems, I can just approve this."

One way to handle this problem would be to require the person who hit "disapprove" to be the one to re-approve since they'll know if their concerns were addressed.

Caleb pointed out that opening a separate type of issue would solve this quite well too - and wouldn't require the commit to be approved first, which is nice.

Shiue wants something like this because that would allow us to make statements of the form "commit A is approved, but only conditional on the fix in commit E" which is necessary when finding a "latest stable" version to branch from.