Sannis/node-mysql-libmysqlclient — Issue #98: Fails to compile on Ubuntu 11.04/w Node 0.4.12
Author: celer
Created: 2011-10-18 01:57:13+00:00
State: open

Hi Sannis,

Great work! Your most recent commit looks to have caused a reversion, going back to the prior version allows it to compile:

>root@raven:/home/celer/Project# cat /etc/issue.net
>Ubuntu 11.04
>root@raven:/home/celer/Project# date
>Mon Oct 17 19:46:00 MDT 2011
>root@raven:/home/celer/Project# node -v
v0.4.12
root@raven:/home/celer/Project# git clone git://github.com/Sannis/node-mysql-libmysqlclient.git
Cloning into node-mysql-libmysqlclient...
remote: Total 2777 (delta 1961), reused 2225 (delta 1693)
Receiving objects: 100% (2777/2777), 562.65 KiB | 705 KiB/s, done.
Resolving deltas: 100% (1961/1961), done.
root@raven:/home/celer/Project#
root@raven:/home/celer/Project# cd node-mysql-libmysqlclient/
root@raven:/home/celer/Project/node-mysql-libmysqlclient# uname -a
Linux raven 2.6.38-11-generic #50-Ubuntu SMP Mon Sep 12 21:18:14 UTC 2011 i686 i686 i386 GNU/Linux
root@raven:/home/celer/Project/node-mysql-libmysqlclient#
root@raven:/home/celer/Project/node-mysql-libmysqlclient# node-waf configure
Checking for program g++ or c++ : /usr/bin/g++
Checking for program cpp : /usr/bin/cpp
Checking for program ar : /usr/bin/ar
Checking for program ranlib : /usr/bin/ranlib
Checking for g++ : ok
Checking for node path : not found
Checking for node prefix : ok /usr/local
Checking for library mysqlclient_r : yes
Checking for header mysql.h : yes
'configure' finished successfully (1.918s)
root@raven:/home/celer/Project/node-mysql-libmysqlclient# make
node-waf build
Waf: Entering directory `/home/celer/Project/node-mysql-libmysqlclient/build'
[1/5] cxx: src/mysql_bindings.cc -> build/default/src/mysql_bindings_1.o
[2/5] cxx: src/mysql_bindings_connection.cc -> build/default/src/mysql_bindings_connection_1.o
[3/5] cxx: src/mysql_bindings_result.cc -> build/default/src/mysql_bindings_result_1.o
../src/mysql_bindings_connection.cc:455:5: error: prototype for ‘int MysqlConnection::EIO_Connect(eio_req*)’ does not match any in class ‘MysqlConnection’
../src/./mysql_bindings_connection.h:175:17: error: candidate is: static void MysqlConnection::EIO_Connect(eio_req*)
../src/mysql_bindings_connection.cc: In static member function ‘static v8::Handle MysqlConnection::Connect(const v8::Arguments&)’:
../src/mysql_bindings_connection.cc:529:73: error: invalid conversion from ‘void (*)(eio_req*)’ to ‘int (*)(eio_req*)’
../src/mysql_bindings_connection.cc:529:73: error: initializing argument 1 of ‘eio_req* eio_custom(int (*)(eio_req*), int, int (*)(eio_req*), void*)’
../src/mysql_bindings_connection.cc: At global scope:
../src/mysql_bindings_connection.cc:1098:5: error: prototype for ‘int MysqlConnection::EIO_Query(eio_req*)’ does not match any in class ‘MysqlConnection’
../src/./mysql_bindings_connection.h:242:17: error: candidate is: static void MysqlConnection::EIO_Query(eio_req*)
../src/mysql_bindings_connection.cc: In static member function ‘static v8::Handle MysqlConnection::Query(const v8::Arguments&)’:
../src/mysql_bindings_connection.cc:1193:70: error: invalid conversion from ‘void (*)(eio_req*)’ to ‘int (*)(eio_req*)’
../src/mysql_bindings_connection.cc:1193:70: error: initializing argument 1 of ‘eio_req* eio_custom(int (*)(eio_req*), int, int (*)(eio_req*), void*)’
Waf: Leaving directory `/home/celer/Project/node-mysql-libmysqlclient/build'
Build failed: -> task failed (err #1):
{task: cxx mysql_bindings_connection.cc -> mysql_bindings_connection_1.o}
make: *** [mysql_bindings.node] Error 1
root@raven:/home/celer/Project/node-mysql-libmysqlclient#
root@raven:/home/celer/Project/node-mysql-libmysqlclient#
root@raven:/home/celer/Project/node-mysql-libmysqlclient# git checkout 5447e42388
Note: checking out '5447e42388'.
>
>You are in 'detached HEAD' state. You can look around, make experimental
>changes and commit them, and you can discard any commits you make in this
>state without impacting any branches by performing another checkout.
>
>If you want to create a new branch to retain commits you create, you may
>do so (now or later) by using -b with the checkout command again. Example:
>
> git checkout -b new_branch_name
>
>HEAD is now at 5447e42... Add Sergey Novgorodsky to contributors list
>root@raven:/home/celer/Project/node-mysql-libmysqlclient# make
>node-waf build
>Waf: Entering directory `/home/celer/Project/node-mysql-libmysqlclient/build'
>[1/5] cxx: src/mysql_bindings.cc -> build/default/src/mysql_bindings_1.o
>[2/5] cxx: src/mysql_bindings_connection.cc -> build/default/src/mysql_bindings_connection_1.o
>[3/5] cxx: src/mysql_bindings_result.cc -> build/default/src/mysql_bindings_result_1.o
>[4/5] cxx: src/mysql_bindings_statement.cc -> build/default/src/mysql_bindings_statement_1.o
>[5/5] cxx_link: build/default/src/mysql_bindings_1.o build/default/src/mysql_bindings_connection_1.o build/default/src/mysql_bindings_result_1.o build/default/src/mysql_bindings_statement_1.o -> build/default/mysql_bindings.node
>Waf: Leaving directory `/home/celer/Project/node-mysql-libmysqlclient/build'
>'build' finished successfully (4.688s)