bitboxer/git-commit-notifier — Issue #108: group_email_by_push=true: different subject depending on Ruby version
Author: mfn
Created: 2011-10-14 06:52:15+00:00
State: open

I don't know if anyone cares, but we happened to see a difference now that we were using an outdated git-commit-notifier version for a long time, recently upgraded, and saw this different.

When `group_email_by_push` is `true`, the subject between 1.8 vs. 1.9. , specifically `ruby 1.8.7 (2011-06-30 patchlevel 352) [i686-linux]` against `ruby 1.9.2p290 (2011-07-09 revision 32553) [i686-linux]`, is different.

In Ruby 1.8, the Subject is the message of the last commit in the email.

In Ruby 1.9, the Subject is the message of the first commit in the email.

If I were to make a call I'd say the Ruby 1.9 behavior is the expected one; it's also less confusing because the Subject matches the first message to be seen in the email.