clientside/amplesdk — Issue #93: XUL: insertBefore() and toolbarspacer inserts off by one.
Author: h6w
Created: 2011-10-12 04:56:14+00:00
State: open

To continue from issue 92 (which appears to have been blocked from being reopened.)...

On the one hand you say toolbarspacer has been implemented, and then you say it has not. ??

Toolbarspacer elements are similar to toolbarseparator elements. The difference is that toolbarseparator elements are equivalent to separator elements and therefore consist of a visual bar to separate the items. Whereas toolbarspacer elements have no visual component other than space. It would be possible to style a toolbarseparator to hide the bar, but styling messes with flow.

The other possibility is toolbarspring, which is the same as a toolbarspacer with flex="1". However, toolbarspring is not implemented.

Since toolbarspacer has been implemented, I think the safest thing is to simply make toolbarspacer a toolbarseparator without the bar. However, it's still being inserted into the html DOM incorrectly as in issue #92