BeSimple/BeSimpleI18nRoutingBundle — Issue #9: Bundle incompatible with Symfony master
Author: stof
Created: 2011-10-10 18:17:58+00:00
State: open

This bundle is incompatible with the Symfony master branch because of the change in the way the locale is handled.

I see 2 ways to fix it:
- getting the locale from the RequestContext (like the core router does) when generating the route. This is the best solution IMO as it will work for both 2.0 and master (the reason why the bundle uses the session currently is probably because the locale was not available this way when the first implementation was done)
- getting the locale from the request. This will require having 2 versions of the bundle (one for 2.0 and one for master) and will also require making our router container-aware because of the scope issue.

I would personally vote for the first way. I can work on it but it would probably be a good idea to merge the refactoring of #6 first (I could make it part of the refactoring too but I find it a bit unclean). What do you think about it ?