ShareKit/ShareKit — Issue #51: retain self as delegate in SHKSharer - MEMORY LEAK
Author: VilemKurz
Created: 2011-10-10 13:58:30+00:00
State: open

Another retained delegate (SHKSharer.m:274) is causing a leak. However, I am not sure how to cure this.

Scenario: share something on twitter, but not yet authorized. OAuth authorization dialogue with twitter login should appear. But SHKTwitter retains itself before, and never releases. There are callback methods, where [self autorelease] is called, but they are called only if Twitter is already authorized - so that we only are sharing, not authorizing.

After several hours hunting for memory leaks in ShareKit, i feel like this thing is a messed jungle of retained delegates and singletons. :(

It seems like coding (anti)standards were
- retain delegates
- avoid using accessors
- use singletons as often as possible