commontk/CTK — comment on commit 4314c15836b87f2946665bda7e442ecd4593cb16
File: Libs/Widgets/ctkToolTipTrapper.h line 67
By jcfr:

The last point you bring make complete sens, having a tool tip manager or
tool tip decorator seems to be the way to go.

ctkToolTipManager or ctkToolTipDecorator look good to me.

Since the user base is small, we could also easily make sure that everybody
will be aware that ctkToolTipWrapper will disappear and that
ctkToolTipManager (or other name we will choose) will be the way to go. We
could also keep ctkToolTipWrapper

For sake of clarifying a little bit :) What motivated my previous
statements is "readability" + "clear API" + "backward compatibility". The
design that currently exist is confusing and is mixing multiple concepts.
:)

Jc

On Sat, Mar 10, 2012 at 12:40 AM, Julien Finet <
reply@reply.github.com
> wrote:

> I don't think there is enough "feature" to split the class in 2. I believe
> 1 class that contains everything that is tooltip related is good enough.
> Every object can always be split into smaller objects, but the line has to
> be drawn somewhere. What if you want to control the delay, color, position,
> behavior, animation,... of tooltips ? You would create 1 class for each
> property ? You would then need a tooltip manager to control all of those
> properties because you don't want the application developer to manually
> instanciate all those classes. Why not have this ctkToolTipTrapper class be
> directly the "manager" of tooltip properties (display of tooltips:
> visible/hidden, plaintext/richtext...) and keep all of the work in 1 class
> ? Having separate classes sounds a bit over-engineered to me, especially
> when the logic of those can be written in 1 line of code (hide tooltip,
> convert to richtext)
> The name ctkToolTipTrapper might sound a bit too specialized and it could
> be renamed into something more generic (ctkToolTip, ctkToolTipManager, ...).
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/commontk/CTK/commit/4314c15836b87f2946665bda7e442ecd4593cb16#commitcomment-1068542
>

--
+1 919 869 8849