ProjectSkyfire/SkyFireEMU — comment on commit 7f7622a9f8105e89c94ed37b05233f31679f6c99
File:  line 0
By Raydeon:

Ok, before it was just irritating... now it is getting stupid... what database are you using, a trinity 3.3.5? You SHOULD be using the latest skyfireDB. It does not make any logical sense to add a bunch of 3.3.5 quests and no longer valid spells back into our conditions table when they have been removed from the game and/or dbcs... Also, do you test ANY of this stuff before you push it into master? I think if I was testing something (as you should be), I would have seen the 150+ startup errors this generates due to conditions not being properly aligned and or valid (caused by this commit). Seriously dude, if you aren't testing this stuff thoroughly, you DON"T NEED TO BE PUSHING TO MASTER. Put it in a branch or even a fork and test the stuff out first... just because it fixes something in TrinityCore, does NOT mean it automatically fixes anything in this project. Hell, it may not even be needed. ALL stuff ported from trinity needs to be put in a branch, examined, and thoroughly tested before pushing it into our master.

Example: quest 25444
http://www.wowhead.com/quest=25444 - Obsolete. Removed in 4.0.1

Another Example "Aura condition has non existing spell (Id: 48085)"... Of course it is "non existing," that would be because it was removed in 4.0.3.

Some of us are working our asses off to make a solid and up to date database... Crap like this can easily destroy it fast. Please start paying attention to what you are doing... and please revert this before the bitching begins.

NOTE: What is worse about this entire situation is that Alter made a special branch called "conditions" just for this work to be ported to... as it stands now, anyone that runs 2012_03_08_00_world_conditions.sql has completely fucked there conditions table. Anyone who doesn't run it after this commit has completely fucked their condition table... I personally am reverting to an earlier version of skyfire BEFORE you touched the conditions.