siroky/Payola — comment on commit 6410ae0d2f5515b9b1309f292ead945ceeffd5b2
File: payola/common/src/main/scala/cz/payola/common/model/ParameterInstance.scala line 23
By siroky:

Ok, I agree with the first part, let's make it mutable then (leaving value a var as it is now). I think there is no need for setValue method, because the value is public. If the value was protected, it would have some purpose.

Ad Conversions: I think that conversion methods and getters shouldn't be in the trait at all. Taking your arguments ad absurdum, imagine that all classes that wrap primitive types should implement similar methods - to make it easier for user. My opinion is, that if the user wants to convert the value (which won't happen often) he should get the value strongly typed and perform the conversion by himself.

Ad stringValue: instance.toString is a clear winner for me. The default implementation of ParameterInstance.toString can be just "value.toString". And some special subclasses of ParameterInstances may override it if needed.