aelse/ultrajson — comment on commit ea461b22946ff13e1ecb3cb197270ef1acc335f1
File:  line 0
By jskorpan:

Thanks for your contribution and your interest in ultrajson.
I'm deeply aware of that this kind of functionality should be available in ultrajson, I simply haven't found the time to implement it.

Would you be so kind as to add more tests:
What happens if default() throws exception?
What are the contracts of what value and types default() must return and what happens if it doesn't?
Sadly the design of ultrajson is prone to memory leaks if you change types during serialization

I'm also interest in the performance implications of this patch? Did you run the benchmarks?