nico/yasm — comment on commit 01ab853e68ef8aeded716d6f5b34895200f66a51
File:  line 0
By nico:

@PeterJohnson Please let me know if you see any issues with this patch. Here's why I think it's correct:

The section flags are read here:

flags_override = yasm_dir_helper(object, vp, line, help, NELEMS(help),
&data, yasm_dir_helper_valparam_warn);

The only fields of `data` that are read in the following code are `data.f_segname` and `data.align`. `f_segname` is used to look up the section object (using `yasm_object_get_general`), so it will match `msd`'s name no matter if it's new or not. So the only relevant value that's used is `align`. If the alignment matches the previous alignment value, there's no point in printing a warning about it being ignored. If the value is different, the warning is still printed.

I checked locally that this program still warns:

section .rodata align=32
section .rodata align=16

while this doesn't:

section .rodata align=16
section .rodata align=16