ronaldfenner/yii — comment on commit b03e2d04f4a4ff9d1467ef2c186a4f267afb957f
File: framework/base/CModel.php line 634
By ronaldfenner:

Yeah i've already a check in the getter for the false value wondering if i
should check for an empty string and false value in the setter instead and
perhaps set the value to null. Putting the checks in the setter would
negate them needed in the setter.

On Thu, Mar 8, 2012 at 4:45 PM, Maurizio Domba <
reply@reply.github.com
> wrote:

> Would be good to add that to the description.. like "setting this to false
> will be the same as setting to an empty string"
>
> Regarding this... currently we get names like "Model_username" so by
> setting this to false or empty we would get "_username"... would be good to
> check this and then not add the underscore so that we get just the
> attribute name like "username"
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/ronaldfenner/yii/commit/b03e2d04f4a4ff9d1467ef2c186a4f267afb957f#commitcomment-1063266
>