benedictpaten/jobTree — comment on commit 0580ca24d6c8915964edf711f60729f10dacfb9a
File: batchSystems/gridengine.py line 255
By dentearl:

Yeah, jobID, result = updatedJob will break if you pass back a triple in updatedJob and then try to assign only two variables to it. Maybe standardize the return on such a method, or have a call to len, but checking the length seems like a messy solution.

d

On 7 Mar, 2012, at 2:35 PM, Daniel Zerbino wrote:

> Reviewing the code, I'm taking that back: in src/master:
>
> updatedJob = batchSystem.getUpdatedJob(10)
> #pauseForUpdatedJob(batchSystem.getUpdatedJob) #Asks the batch system
> what jobs have been completed.
> if updatedJob != None: #Runs through a map of updated jobs and there
> status,
> jobID, result = updatedJob
>
> So it should return either None, or a valid tuple. Unless I'm missing
> another piece of code...?
>
> On 07/03/2012 14:20, Dent Earl wrote:
>> Shouldn't this initialization be
>> i = (None, None, None)
>> Since you're now expecting this function to return a triple? See the call made bygetUpdatedJobs().
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/benedictpaten/jobTree/commit/0580ca24d6c8915964edf711f60729f10dacfb9a#commitcomment-1055948
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/benedictpaten/jobTree/commit/0580ca24d6c8915964edf711f60729f10dacfb9a#commitcomment-1056007