delai/flask-admin — comment on commit 037c4c759a3dd2b76ff18f20d56426b7a2ee0a43
File:  line 0
By wilsaj:

The column stuff looks good from here - I probably won't have a chance to test/merge until tomorrow.

Sorry to nitpick on a minor thing but I'm not sure about changing the docstrings in core.py and init.py to use the term primary key. The keys at the datastore level don't necessary have to map to primary keys. At the datastore level, a model key is just some unique way of representing a value. We could have datastores that don't use the term **primary** key. The mongoalchemy datastore is an example of this - the concept of primary keys doesn't really exist in mongo, rather values are keyed by UUIDs. The current implementation of the SQLA datastore uses primary keys, but surrogate keys would work just as well as long as they can uniquely identify model instances. And support for surrogate keys is something I'd like to add in the future.