isartcanyameres/opennaas — comment on commit c473404ed9e194f9596753c7395d878b56a1af5c
File:  line 0
By gbehrmann:

Several comments:

- Changes like these are not related to OSPF and thus shouldn't be part of a feature branch to add OSPF support (probably too late now, but something to keep in mind for the future - consider this: You made a pull request containing over 60,000 changed lines of code. How can this possibly be reviewed?).
- These model classes are auto-generated with the mofcomp tool. Auto generated code should not be modified by hand as any such modifications are lost when then code is regenerated (as will happen when you update Mantychore to the next revision of CIM). For this reason auto-generated code should also not be checked into the repository. It is better to generate it as part of the build process.
- Is it really part of your coding conventions to break the max 80-char width rule commonly used in Java and other programming languages? This is why IDEs typically have a red line at this column. Printing code, viewing in terminal windows, or simply on small screen devices becomes considerably more difficult when you don't adhere to the 80-char rule (for a list of good coding conventions to add to the official Sun/Oracle conventions see: http://geosoft.no/development/javastyle.html).