polotek/procstreams — comment on commit 8c4cd24d7b7c7ede75e8d8c55588bc9e354bcd13
File: procstreams.js line 105
By jstewmon:

This doesn't look right to me, but maybe it's a matter of expected use...

If the child process exits with an error, but there is no error using the stdin or stdout streams, then `err` will be null. Is it your intent that the callback passed to `data` only gets an error is emitted by the streams represented by stderr and stdout?

I understand the reason why you separated the "data" from the "exited with error" event, but I'm still thinking that it's more convenient to be able to access stderr from the same function that is notified that a child prcoess exited with an error. I'll leave one more comment on what I think could be done about that...