silverstripe-scienceninjas/sapphire — comment on commit 927dbbe717be3975c3e763bd462a8b6ebbe0a035
File: view/TemplateGlobalProvider.php line 12
By sminnee:

Yeah when I wrote that first part I misunderstood the implementation. ;-)

As for the second part, the way I would see it happening is that, you decide "okay what's necessary is a generic document. i'll put the first part of that in with this pull request". One of the motivations for moving to markdown docs was to minimise the distance between a feature's implementation and its documentation appearing.

It doesn't block the pull request, but as a general practise it would be nice to see docs coming along with new APIs.