silverstripe-scienceninjas/sapphire — comment on commit 927dbbe717be3975c3e763bd462a8b6ebbe0a035
File: security/Permission.php line 627
By hafriedlander:

Hmm. Because we don't specify when getExposedVariables is called, is there a situation where you'd want an instance object? I don't like declaring functions inline - that seem's like API supporting a smell.

It does get a bit weird with TemplateIteratorProviders because we explicitly construct an instance to call the method on (so on TemplateGlobalProviders the method is called statically, on TemplateIteratorProviders it's called on an instance we construct)