jakevdp/scipy — comment on commit 2cb002ced9db09d33646a21a3ef96042b37f4f10
File:  line 0
By josef-pkt:

(Sorry, I haven't been keeping track much of scipy pull requests recently)

Just a quick browse through the algorithm, i haven't looked at the binning part yet.

Overall I think this looks good. I remember parts of it from np.histogramdd, and bincount should be reasonably fast. Did you compare notes with ndimage.measurements? The c code there has been replaced with a similar code, but I don't remember the details.

The statistics part could eventually be replaced by a groupby functionality in numpy, A (visual?) separation between the binning and the groupby parts might be useful later on. Or maybe it's already separated enough.

The tests are drawing lots of random numbers. The random numbers should have a fixed seed. One possibility would be to put all tests into a class, so that the random numbers could be reused (generated once in a setupclass ? method)
Can some random number tests be replaced by just a simple explicit example? e.g. hardcoding one draw of the random numbers with a smaller number of observations (which could be manually verified)?

Are the binning and binning options the same as for histogram? I didn't check the details.