Davidiusdadi/Java-WebSocket — comment on commit 2392776ece21194ad63be1002d2fdaa0143aa897
File: src/net/tootallnate/websocket/WebSocket.java line 100
By detro:

Well, you must using a "simple text editor too", given how you spelled
"received". Eclipse and IntelliJ do have misspell correction. Turn it
on.

I will commit a patch to this: surprising that IntelliJ (that
sometimes I do use) didn't pick up that.
Maybe it boils down to human error: blaming tools is stupid if you ask me.

Btw, I'm honestly surprised you are picking stuff out of my fork. I
assumed we were going on our own ways because you didn't like my code
formatting or that I did maintenance tasks (that should be reserved to
repository maintainers).

I'll keep working on my own fork for now and improving (and fixing
mistakes): at the moment the only real feature I think I miss is
support for WSS. Everything else, if it's not there, can easily be
arranged.

---
Ivan De Marino
Coder, Technologist, Cook, Italian

Sent on the move

On 3 Mar 2012, at 15:04, David Rohmer

wrote:

> These minor correction cause NullPointerExceptions because you did not changed sockchannel in line 101.
>
> Making such changes without a refactoring tool is risky...
> You use a simple text editor, don't you?
>
> I'd suggest not to change case-sensitivity. Currently there should not be any variables with upper letters in it.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Davidiusdadi/Java-WebSocket/commit/2392776ece21194ad63be1002d2fdaa0143aa897#commitcomment-1038785