jeffreybreen/RHadoop — comment on commit 6f5082feea31b42d53ebac5919f59975e11eb88b
File:  line 0
By piccolbo:

This is of course welcome but there are two comments. The first is: how many of these scripts can we possibly accept? This is a problem with whirr, that it doesn't accept parameters for the scripts. So one can't generalize and has to rely on duplication of code. I have a ticket submitted to the the whirr guys (WHIRR-448 which is actually a slightly different thing so perhaps we need to file a different one) and I will try and see what's happening. The other, and it is probably my ignorance of how git works, is that this is not an emergency fix, it is an additional feature so I would like to pull it into dev, not master. I wonder if I can do that or if you have to fork dev to start with. Our process is a bit in flux but ideally I would like to have master always tested on standalone and a cluster and have it receive only hotfixes or merges from a release branch. dev should move more freely, I normally check in without breaking it but I do not always run R CMD check before doing so, only when I am making important changes. When it's time to release I would create a release branch, go in feature freeze, fix bugs, run checks, run through the documentation and then merge into both dev and master at the same time.