gheorghelisca/cram_pr2 — comment on commit cf965d03eeaff3e6d46c3eaedd67b23120bec782
File: pr2_manipulation_process_module/src/process-module.lisp line 589
By moesenle:

Please put test functions into a separate ros package, maybe even in a different package. At least use a different file to indicate that the functions in that file are not necessary for the package do function properly. The file process-module.lisp should only contain functions that are related to the process module.

Please respect the common lisp coding style used above. Your code is really really hard to read. Lisp is not c, so don't try to mirror C's syntax. In short:

- avoid unnecessary whitespaces and blank lines
- closing parenthesis are never on a single line.
- try to avoid abreviations (I know, the code doesn't respect that completely, but I'm refactoring it...). A variable name such as tr is bad because it's not really expressive. Better use something like carry-pose-trajectory