zhhealthcare/openemr — comment on commit 07cdb1e0f48d33e0d25ce52363b3428106d51c75
File: interface/patient_file/front_payment.php line 415
By yehster:

Doing it through binding would simplify defining useful constants though. What makes this particularly confusing, is no one besides the person who wrote this section know what '4' represents.

That's the true "bad practice".
I'd like to see a separate file somewhere like
define('ENC_LEVEL_FINISHED','1);
define('ENC_LEVEL_UNBILLED','2);
define('ENC_LEVEL_CLAIMS_SUBMITTED','3);
define('ENC_LEVEL_PAYMENT_RECEIVED,'4);
(note' I'm totally making up what I think the levels might represent.)

All the instances where integers are being inserted which represent more than just the number should be defined.

So in this case, even though it's a constant, this would be so much more readable than
array(ENC_LEVEL_PAYMENT_RECEIVED,$enc,$form_pid));
the orignal code.