gheorghelisca/cram_pr2 — comment on commit cf965d03eeaff3e6d46c3eaedd67b23120bec782
File:  line 0
By moesenle:

All in all, I think your code isn't too bad. Your style though needs a lot of improvement :) Please try to respect common lisp style used in all my lisp files. That's something really important.

Notes on the organization of the source code: The process modules should not contain any user code such as: move to a specific location. This belongs to the high-level executive. Please create a sandbox package similar to cram_pr2_executive where you can put your high-level code in. Please make your open and close functions more general, i.e. they should get a side and a pose parameter. Please also have a look at the designator.lisp file. Replace the container-open and container-closed action handlers in process-module.lisp with your code for opening and closing the container. Best if you learn about macros and how macro expansion can be done in slime (C-c C-m) to understand the def-action-handler macro.